Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownMenu: Fix shifting menu items #16871

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@noisysocks
Copy link
Member

commented Aug 2, 2019

Fix menu items in the More menu from shifting horizontally when selected. This was noticed while testing #14851.

Before:

before

After:

after

I'm not really confident that I fixed this the right way. I'm unclear to me whether the margin between the text and icon is supposed to be 4px per IconButton:

Or if it's supposed to be 5px per MenuItem:

I could really use some of that @jasmussen magic right now! 馃檹

DropdownMenu: Fix shifting menu items
Fix menu items in the More menu from shifting horizontally when
selected.
@gziolo

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

I figured out that, it might have regressed in #14843. Although, we were mostly moving styles to different files during that refactoring.

@karmatosed karmatosed self-requested a review Aug 2, 2019

@karmatosed
Copy link
Member

left a comment

Great fix to me! Seems good to go for design review as a catch of an issue.

@mapk
mapk approved these changes Aug 7, 2019
Copy link
Contributor

left a comment

:shipit:

@karmatosed karmatosed merged commit 60ec8fe into master Aug 9, 2019

3 of 48 checks passed

Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
First Time Contributor First Time Contributor
Details
Assign Fixed Issues Assign Fixed Issues
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Travis CI - Pull Request Build Passed
Details

@github-actions github-actions bot added this to the Gutenberg 6.3 milestone Aug 9, 2019

@youknowriad youknowriad deleted the fix/shifting-menu-items branch Aug 10, 2019

gziolo added a commit that referenced this pull request Aug 29, 2019
DropdownMenu: Fix shifting menu items (#16871)
Fix menu items in the More menu from shifting horizontally when
selected.
gziolo added a commit that referenced this pull request Aug 29, 2019
DropdownMenu: Fix shifting menu items (#16871)
Fix menu items in the More menu from shifting horizontally when
selected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.