Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality of table e2e tests #16872

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@talldan
Copy link
Contributor

commented Aug 2, 2019

Description

Small PR that implements some code quality updates for table block e2e tests. Addresses feedback on #16653 and #16111.

Changes:

  • Use the clickButton utility instead of elementHandle.click.
  • Avoid typing loads of text when line breaks can be used.
  • Prefer array destructuring when possible.
  • Fix an incorrect comment.

How has this been tested?

  • Ensure E2E tests pass.

Types of changes

Code quality.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@gziolo
gziolo approved these changes Aug 2, 2019
Copy link
Member

left a comment

Tests still pass, code changes look good, nice cleanup 👍

@talldan talldan merged commit e73a07a into master Aug 2, 2019

3 of 36 checks passed

Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
First Time Contributor First Time Contributor
Details
Assign Fixed Issues Assign Fixed Issues
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Travis CI - Pull Request Build Passed
Details

@talldan talldan deleted the update/table-e2e-tests branch Aug 2, 2019

@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.