Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add section about adding new dependencies to WordPress packages #16876

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@gziolo
Copy link
Member

commented Aug 2, 2019

Description

This PR adds a section about adding new dependencies to WordPress packages. See new section's preview:
https://github.com/WordPress/gutenberg/blob/a300ed9530b7b4746924194b75117678e3592cc7/packages/README.md#adding-new-dependencies

I came up to the conclusion that this needs to be explained explicitly after talking to @dsifford. He had some issues when he wanted to add a new dependency to one of the packages. I hope all the proposed changes will make it easier for future contributors.

@gziolo gziolo requested review from ntwb, nerrad and dsifford Aug 2, 2019

@gziolo gziolo self-assigned this Aug 2, 2019

@gziolo gziolo requested a review from chrisvanpatten Aug 2, 2019

@dsifford
Copy link
Contributor

left a comment

LGTM 👍

@chrisvanpatten
Copy link
Member

left a comment

A few grammar nits, but this is great and super helpful!

packages/README.md Outdated Show resolved Hide resolved
packages/README.md Outdated Show resolved Hide resolved
packages/README.md Outdated Show resolved Hide resolved
Apply suggestions from code review
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
@gziolo

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

A few grammar nits, but this is great and super helpful!

They should hire you at Grammarly to improve their system which catches grammar issues, thanks for all corrections. 😄

@chrisvanpatten
Copy link
Member

left a comment

🚢!

@gziolo gziolo merged commit eb84467 into master Aug 5, 2019

1 of 4 checks passed

Filter opened Filter opened
Details
Filter opened Filter opened
Details
Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details

@gziolo gziolo deleted the update/docs-adding-deps-packages branch Aug 5, 2019

@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019

gziolo added a commit that referenced this pull request Aug 29, 2019
Docs: Add section about adding new dependencies to WordPress packages (
…#16876)

* Docs: Add section about adding new dependencies to WordPress packages

* Apply suggestions from code review

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
gziolo added a commit that referenced this pull request Aug 29, 2019
Docs: Add section about adding new dependencies to WordPress packages (
…#16876)

* Docs: Add section about adding new dependencies to WordPress packages

* Apply suggestions from code review

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.