Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
RichText 🧹 (clean up, move Autocomplete, remove DOM dependency) #16905
I renamed this branch because @frontdevde had problems pulling Gutenberg because of the emoji in the branch name.
This PR mostly moves code around.
How has this been tested?
E2e tests should pass.
Types of changes
gziolo left a comment •
This PR still needs to be rebased after some changes applied to
I tested a few blocks including Paragraph, Galler and List toghether with the autocompletion and everything works as expected.
I'm not fully skilled to process all changes around new
I'm not sure who else would be more skilled. I merely moved some code around and sorted it by
activeFormats.length || ( isReverse && start !== 0 ) || ( ! isReverse && end !== text.length )
so that we use the internal rich text value instead of the DOM to determine when to merge/delete.
It's the same thing.
Since we're at the start of a release cycle, I'll merge this now, so we can continue work on top of this, and there is enough time to catch problems if any appear.