Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Fields: Update test snapshot with the new checkbox implementation #16918

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@marekhrabe
Copy link
Contributor

commented Aug 6, 2019

Description

I have merged my PR #15688 onto master where it got an updated implementation of checkboxes from #16551 and that unfortunately broke test snapshots. This PR updates them.

My original PR should have been rebased before merging, despite the merge looking clean. Rebasing would have surfaced this.

Failed merge: https://travis-ci.com/WordPress/gutenberg/builds/122051161?utm_medium=notification&utm_source=email

How has this been tested?

Tested by running unit tests 馃槈npm run test-unit

@marekhrabe marekhrabe requested a review from talldan as a code owner Aug 6, 2019

@marekhrabe marekhrabe self-assigned this Aug 6, 2019

@ntwb
ntwb approved these changes Aug 6, 2019
Copy link
Member

left a comment

LGTM 馃憤

@gziolo gziolo merged commit f52b01d into master Aug 6, 2019

3 of 12 checks passed

Filter opened Filter opened
Details
Filter opened Filter opened
Details
First Time Contributor First Time Contributor
Details
Assign Fixed Issues Assign Fixed Issues
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Travis CI - Pull Request Build Passed
Details

@gziolo gziolo deleted the fix/custom-fields-test branch Aug 6, 2019

@gziolo gziolo added this to the Gutenberg 6.3 milestone Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.