Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Editor: Update the store to use Core Data entities. #16932
This PR picks up from where #16903 left off in the planned entities refactor. It almost completely rewrites the editor store to act as a thin routing interface between the Block Editor and Core Data entities, in preparation for multi-entity editor setups for full site editing.
How has this been tested?
The existing tests were refactored to work with the new code.
youknowriad left a comment
Quickly looking at the code, it looks great. I love how this simplifies a lot of things. The different responsibilities become way clearer.
Do you know why the tests are failing? I feel like tests failing in big refactorings can have a lot of impact so I'd prefer to wait before doing a deeper review.
No idea, but it looks pretty scary. I'll see what's going on and ping you when I know more.
3 times, most recently
Aug 8, 2019
Aug 9, 2019
gziolo left a comment •
It's great to see this refactoring happening. We will benefit from it immensely in the long run.
I have some concerns with regards to unit tests. They are essential for this part of the application in the context of maintenance. This is a very complex code and only a good set of unit and e2e tests can help us ensure it's easier to update for a wider group of contributors. In some places, I'm not 100% we that removed tests shouldn't be replaced with their corresponding version translated to the new conditions. However, with the huge number of lines updated in this PR it's hard to tell whether I make correct assumptions.
Aug 22, 2019
I see some regressions after this PR, after a quick round of testing. Not sure if it's all because of this PR.
If feel like we should have added more undo e2e tests before rewriting.