Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Make tapping at end of post always insert at end of post #16934

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@mchowning
Copy link
Contributor

commented Aug 6, 2019

related gutenberg-mobile PR

Description

This fixes an issue where tapping on the empty area at the end of a post to add a new block would add the block after the currently selected block instead of the end of the post (related comment and parent issue: gutenberg-mobile#358). Previously, tapping at the end of the post would insert a block immediately after the currently selected block.

In addition, this PR also cleans up some props that are no longer used since the recent PR refactoring BlockList was merged.

Before After
before mp4 after mp4

How has this been tested?

  1. In a post with multiple blocks, select any block other than the last block
  2. Tap on the empty space at the end of the post to add a new block.
  3. Verify that the new block is inserted at the end of the post.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@mchowning mchowning self-assigned this Aug 6, 2019

@mchowning mchowning referenced this pull request Aug 6, 2019
1 of 1 task complete

@mchowning mchowning force-pushed the rnmobile/cleanup_block-list branch from 38d9de7 to 4141812 Aug 20, 2019

@mchowning mchowning requested review from Tug and etoledom Aug 20, 2019

@etoledom
Copy link
Contributor

left a comment

Looks and works great 🎉

Tested on iOS and Android.
Thank you @mchowning !

@mchowning mchowning force-pushed the rnmobile/cleanup_block-list branch from 4141812 to 1d09c69 Aug 21, 2019

[RNMobile] Insure tapping at end of post inserts at end
Previously, tapping at the end of the post would insert a block
immediately after the currently selected block. In addition, this commit
is cleaning out a few unusued props in the block-list file.

@mchowning mchowning force-pushed the rnmobile/cleanup_block-list branch from 1d09c69 to 09880a8 Aug 22, 2019

@mchowning mchowning merged commit 7d3de4c into master Aug 22, 2019

2 checks passed

pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details

@mchowning mchowning deleted the rnmobile/cleanup_block-list branch Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.