Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Block paddings on the widget screen. #16944

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 7, 2019

Description

Fixes: #16600

This PR increases the width of the block widgets areas and reduces the padding to make blocks have a bigger space.

How has this been tested?

I enabled the experimental widgets screen on the settings page.
I went to the widgets screen.
I verified the content width is bigger and the padding is lower (when compared to the master).

// By default the default block appender inserter has a negative position,
// but given that on the widget screen we have 0 padding we need to remove the negative position.
.block-editor-default-block-appender .block-editor-inserter,
.block-editor-block-list__empty-block-inserter {

This comment has been minimized.

Copy link
@youknowriad

youknowriad Aug 8, 2019

Contributor

I think these can be nested, do we want that config for all the nested appenders?

This comment has been minimized.

Copy link
@jorgefilipecosta

jorgefilipecosta Aug 8, 2019

Author Member

Hi @youknowriad, nested appenders have a CSS rule with much higher specificity that overwrites this value. Ther value was already different between the top-level appenders and nested ones in the edit-post.

@jorgefilipecosta jorgefilipecosta force-pushed the fix/block-paddings-on-the-widget-screen branch from f79f7ec to 48251de Aug 8, 2019

@youknowriad

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

The width seems ok. I'd appreciate a check from @mapk

I noticed that the blocks are too "condensed" (there's no margins between them). Probably unrelated with this PR but should we apply the same margins as we do in the content editor.

@mapk

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Just checked, and it looks much better now! Thanks! :shipit:

Example:

Screen Shot 2019-08-09 at 11 20 32 AM

@jorgefilipecosta jorgefilipecosta merged commit 399e5e1 into master Aug 10, 2019

1 of 4 checks passed

Filter opened Filter opened
Details
Filter opened Filter opened
Details
Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/block-paddings-on-the-widget-screen branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.