Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText: Fix intermittent test failure #16952

Merged
merged 2 commits into from Aug 7, 2019

Conversation

@ellatrix
Copy link
Member

commented Aug 7, 2019

Description

After #16875, this fixes one of the new e2e tests that sometimes fails.

The problem is that we don't wait for the next animation frame:

this.rafId = window.requestAnimationFrame( this.onSelectionChange );

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@ellatrix

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

Going to merge this as it's just a test change without any other code changes.

@ellatrix ellatrix merged commit 0ca4756 into master Aug 7, 2019

1 of 4 checks passed

Filter opened Filter opened
Details
Filter opened Filter opened
Details
Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details

@ellatrix ellatrix deleted the fix/rich-text-e2e branch Aug 7, 2019

@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019

gziolo added a commit that referenced this pull request Aug 29, 2019
RichText: Fix intermittent test failure (#16952)
* Fix intermittent test failure

* Add comment
gziolo added a commit that referenced this pull request Aug 29, 2019
RichText: Fix intermittent test failure (#16952)
* Fix intermittent test failure

* Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.