Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add table block keyboard navigation #16957
This PR implements improved keyboard navigation within the table block. Previously only tab could be used to navigate cells.
This PR implements the following changes:
The implementation follows the described behaviours here and uses a roving tabIndex:
The changes here open up the possibilities for other future enhancements to the table block:
How has this been tested?
Added e2e and unit tests
Types of changes
New feature (non-breaking change which adds functionality)
2 times, most recently
Aug 9, 2019
ellatrix left a comment •
Thanks for working on this!
Aside from the few comments I left, I have some bigger thoughts on the implementation. I feel like we're reimplementing a lot of what
See also #14675. It would also be good to split this into multiple pieces:
I just tested this and it's working wonderfully! It's so great to be able to arrow through the cells now. Thanks for this.
Thanks for all the feedback.
@ellatrix It does seem like the
It could check for particular parent elements (
It'd be pretty amazing if that worked out of the box. I'll do some investigation.
edit: re-reading your comments, I see what you mean about 'visual positioning', which would mean looking for a physically positioned element below the current selection.
Thanks @talldan, that would be great! I strongly believe it all belong in