Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
RichText: ignore selection changes during composition #16960
This PR fixes input composition after #16875. We're checking selection during
This is done already for the
Unfortunately I'm not able to write any e2e tests. Puppeteer won't compose characters when given the right sequence of keys, and I'm not succeeding at emulating it. I cannot recreate the internal state and UI that the browser has, and it's this state that gets destroyed if we record any input or selection during composition.
The line under this backtick means that the browser is composing. Any ideas are welcome here.
How has this been tested?
This depends a bit on your keyboard layout. For a US/QWERTY layout:
The result should be
Types of changes