Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Button Block appender to the widgets screen #16971

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 8, 2019

Description

This PR adds the button block appender used the group block and columns to the widget areas.

How has this been tested?

I went to the widgets screen and verified a button appender was always available.

Screenshots

Screenshot 2019-08-08 at 19 39 59

@mapk

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

I love the button appender there now!

The actual block should align with the appender now. So, because there's so much spacing on the left and right side of the block, I suggest we extend the block to widen to the width of the Button Appender.

Looks like just removing the left/right padding of 43px from the .block-editor-block-list__layout .block-editor-block-list__block should achieve that.

Screen Shot 2019-08-08 at 5 53 25 PM

@jorgefilipecosta jorgefilipecosta force-pushed the add/button-appender-to-the-widgets-screen branch 2 times, most recently from 46b4a65 to 5d6784e Aug 13, 2019
@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Hi @mapk the block padding was changed in other PR. I don't think we can increase the available space now, otherwise, the block movers would touch the widget area border. The appender is now aligned with the blocks (possible to confirm using the image placeholder).

@mapk
mapk approved these changes Aug 13, 2019
Copy link
Contributor

left a comment

Hey @jorgefilipecosta, it looks and works fantastic now! Thanks. :shipit:

Screen Shot 2019-08-13 at 8 38 21 AM

@jorgefilipecosta jorgefilipecosta force-pushed the add/button-appender-to-the-widgets-screen branch from 5d6784e to 4f21aad Aug 13, 2019
@jorgefilipecosta jorgefilipecosta merged commit 387d85a into master Aug 13, 2019
4 checks passed
4 checks passed
Filter opened
Details
Filter opened
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the add/button-appender-to-the-widgets-screen branch Aug 13, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.