Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add overflow support inside block switcher #16984

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@senadir
Copy link
Contributor

commented Aug 9, 2019

Third time's a charm
closes following issues:
#10905
#16028

replaces PR:
#16824
#16697

fixes some issues with the component popover not having overflow scrolling when the list is long

It adds flexbox support to the component to remove the need for overflow: visible and having problems with long lists of preview options.
block-preview

@senadir

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

@kjellr third time's a charm, continuing from here

@kjellr
kjellr approved these changes Aug 12, 2019
Copy link
Contributor

left a comment

This works well. Tested in Safari, FF, and Chrome for MacOS, and also Safari on iOS. I can confirm it fixes both #10905 and #16028. I left one incredibly minor note, but other than that this should be good to go.

Thanks for sticking with this one, @senadir!

@senadir senadir merged commit cd6f74c into master Aug 12, 2019
1 of 4 checks passed
1 of 4 checks passed
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@senadir senadir deleted the try/overflow-inside-popover branch Aug 12, 2019
@senadir senadir added this to the Future milestone Aug 12, 2019
@senadir senadir modified the milestones: Future, Gutenberg 6.4 Aug 20, 2019
gziolo added a commit that referenced this pull request Aug 29, 2019
* add overflow support inside block switcher
gziolo added a commit that referenced this pull request Aug 29, 2019
* add overflow support inside block switcher
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
* add overflow support inside block switcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.