Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document server functions in block style variations section #16997

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 10, 2019

This PR documents the server-side functions register_block_style and un register_block_style added in #16356 inside the block style variations section.

Copy link
Member

left a comment

A smattering of tweaks, but this is awesome. Thanks for documenting it 🔥

@jorgefilipecosta jorgefilipecosta force-pushed the update/expand-the-block-style-variations-documentation-to-document-server-functions branch 2 times, most recently from 4f22ecc to 144f7cf Aug 12, 2019
@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

Hi @chrisvanpatten thank you a lot for the review and the suggestions. All your suggestions were applied.

@jorgefilipecosta jorgefilipecosta dismissed chrisvanpatten’s stale review Aug 19, 2019

Suggestions were applied

jorgefilipecosta and others added 16 commits Aug 10, 2019
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
@jorgefilipecosta jorgefilipecosta force-pushed the update/expand-the-block-style-variations-documentation-to-document-server-functions branch from 144f7cf to c371a74 Aug 19, 2019
Copy link
Contributor

left a comment

It's weird that this page is called "Block Filters". It's about Block Extensibility in general I think?
Anyway, separate question.

LGTM 👍

@jorgefilipecosta jorgefilipecosta merged commit e6c5ce0 into master Aug 20, 2019
4 checks passed
4 checks passed
Filter opened
Details
Filter opened
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the update/expand-the-block-style-variations-documentation-to-document-server-functions branch Aug 20, 2019
donmhico added a commit to donmhico/gutenberg that referenced this pull request Aug 27, 2019
…s#16997)

* Expand the block style variations documentation to document server functions

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Fix line break and code block closing
gziolo added a commit that referenced this pull request Aug 29, 2019
* Expand the block style variations documentation to document server functions

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Fix line break and code block closing
gziolo added a commit that referenced this pull request Aug 29, 2019
* Expand the block style variations documentation to document server functions

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Fix line break and code block closing
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
…s#16997)

* Expand the block style variations documentation to document server functions

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>

* Fix line break and code block closing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.