Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update: Use some mixins in button styles instead of media queries. #17012

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 12, 2019

Description

Probably soon our mixins will have additional logic e.g: to force mobile styles even if the window is big. It is important that we avoid media queries as much as possible and try to use the mixins.
This PR fixes two direct cases I found where mixins could be used instead of a media query.

How has this been tested?

I added a button block and verified the link field continued to work as before.

@jorgefilipecosta jorgefilipecosta merged commit eebf33b into master Aug 13, 2019
1 of 22 checks passed
1 of 22 checks passed
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the update/use-some-mixins-in-button-instead-of-media-queries branch Aug 13, 2019
@senadir senadir added this to the Gutenberg 6.4 milestone Aug 25, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.