Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Data: Return updated record in `saveEntityRecord`. #17030

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@epiqueras
Copy link
Contributor

commented Aug 14, 2019

Description

This PR makes saveEntityRecord from core-data return the updated record like it did before #16867. Some plugins expect this behavior and the change was not backwards compatible.

How has this been tested?

A test case was added for this behavior to avoid regressions.

Types of Changes

Bug Fix: Rollback breaking change of not returning the updated record in saveEntityRecord from core-data.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@epiqueras epiqueras added this to the Gutenberg 6.3 milestone Aug 14, 2019
@epiqueras epiqueras requested review from nerrad and youknowriad as code owners Aug 14, 2019
@epiqueras epiqueras self-assigned this Aug 14, 2019
@youknowriad youknowriad merged commit be7db4f into master Aug 14, 2019
16 checks passed
16 checks passed
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to Done in Phase 2 via automation Aug 14, 2019
@youknowriad youknowriad deleted the fix/no-return-value-in-save-entity-record branch Aug 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Phase 2
  
Done
2 participants
You can’t perform that action at this time.