Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the double scrollbar appearing in full screen mode #17031

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@youknowriad
Copy link
Contributor

commented Aug 14, 2019

Fix regression introduced by #16856

The fact that "border-box: sizing" is not applied consistently now across all the elements cause this unnecessary scrollbar to show up in the full-screen mode.

@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 14, 2019
@youknowriad youknowriad requested review from jasmussen, afercia and senadir Aug 14, 2019
@youknowriad youknowriad requested a review from talldan as a code owner Aug 14, 2019
@youknowriad youknowriad self-assigned this Aug 14, 2019
Copy link
Contributor

left a comment

Tested, LGTM
screenshot
image

Copy link
Contributor

left a comment

Confirmed! Very nice catch.

Tested with and without fullscreen mode, and other configurations, including mobile, top toolbar and various breakpoints. Ship it.

@youknowriad youknowriad merged commit 9c4ee6f into master Aug 14, 2019
22 checks passed
22 checks passed
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Filter opened
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the fix/double-scrollbar-fullscreen branch Aug 14, 2019
@jasmussen

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

💥

Thank you Riad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.