Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove borders around inserter items for blocks with children blocks #17083

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@youknowriad
Copy link
Contributor

commented Aug 19, 2019

closes #17068

Some blocks (the ones with children items like the "Contact Info" block from Jetpack) appear with a double border in the inserter. This has proven to be confusing and not valuable. This PR removes this special treatment.

@youknowriad youknowriad requested review from ellatrix and talldan as code owners Aug 19, 2019
@youknowriad youknowriad self-assigned this Aug 19, 2019
@youknowriad youknowriad requested review from jasmussen and mapk Aug 19, 2019
@jasmussen

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Before:

Screenshot 2019-08-19 at 12 55 52

After:

Screenshot 2019-08-19 at 12 56 13

It definitely makes sense to not distinguish between blocks here. So in that vein, 👍 👍.

@@ -21,21 +20,14 @@ function InserterListItem( {
backgroundColor: icon.background,
color: icon.foreground,
} : {};
const itemIconStackStyle = icon && icon.shadowColor ? {

This comment has been minimized.

Copy link
@jasmussen

jasmussen Aug 19, 2019

Contributor

Does this remove the support for coloring icons entirely? Or just coloring the stack?

This comment has been minimized.

Copy link
@youknowriad

youknowriad Aug 19, 2019

Author Contributor

just the stack

@jasmussen jasmussen self-requested a review Aug 19, 2019
Copy link
Contributor

left a comment

Yerp, from a design POV 👍 👍

@youknowriad youknowriad merged commit c819d0e into master Aug 19, 2019
4 checks passed
4 checks passed
Filter opened
Details
Filter opened
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the remove/inserter-items-has-children branch Aug 19, 2019
@senadir senadir added this to the Gutenberg 6.4 milestone Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.