Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard block component against zombie state bug #17092

Merged
merged 2 commits into from Aug 19, 2019

Conversation

@senadir
Copy link
Contributor

commented Aug 19, 2019

fixes #17013
implements this fix by @nerrad
#17013 (comment)
gif that shows a paragraph being transformed to a heading in the cover component

@nerrad
nerrad approved these changes Aug 19, 2019
Copy link
Contributor

left a comment

👍

@senadir senadir merged commit dc659b5 into master Aug 19, 2019
4 checks passed
4 checks passed
Filter opened
Details
Filter opened
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@senadir senadir deleted the fix/guard-against-zombie-state branch Aug 19, 2019
@youknowriad

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

An e2e test for this one would be good.

@senadir

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

should we build it against the Cover block or some other block that implements innerBlocks

@youknowriad

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

It doesn't really matter @senadir we can just use the Cover block.

@senadir senadir added this to the Gutenberg 6.4 milestone Aug 20, 2019
gziolo added a commit that referenced this pull request Aug 29, 2019
* Guard block component against zombie state bug
gziolo added a commit that referenced this pull request Aug 29, 2019
* Guard block component against zombie state bug
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
* Guard block component against zombie state bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.