Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links on available SlotFills #17097

Merged
merged 2 commits into from Aug 28, 2019

Conversation

@lukecarbis
Copy link
Contributor

commented Aug 20, 2019

No description provided.

Copy link
Contributor

left a comment

@lukecarbis Thanks for the PR. The trouble with removing the extension is that the links no longer work within github.

I had a look at some other links in the documentation, and it seems as though they all still included the .md extension, the handbook must strip this off when generating the docs. An example is the links in the Block API section that work in both places:
https://github.com/WordPress/gutenberg/blob/master/docs/designers-developers/developers/block-api/README.md

The main difference seems to be that all the other links seem to be absolute, so I think changing these to absolute paths will fix the issue.

* [PluginPrePublishPanel](./plugin-pre-publish-panel.md)
* [PluginSidebar](./plugin-sidebar.md)
* [PluginSidebarMoreMenuItem](./plugin-sidebar-more-menu-item.md)
* [PluginBlockSettingsMenuItem](./plugin-block-settings-menu-item)

This comment has been minimized.

Copy link
@talldan

talldan Aug 20, 2019

Contributor

Comparing to other links in the handbook, it seems like absolute paths are needs for the handbook to correctly process them.

Suggested change
* [PluginBlockSettingsMenuItem](./plugin-block-settings-menu-item)
* [PluginBlockSettingsMenuItem](/docs/designers-developers/developers/slotfills/plugin-block-settings-menu-item.md)

This comment has been minimized.

Copy link
@gziolo

gziolo Aug 27, 2019

Member

Yes, this is correct. @lukecarbis - can you update all those links?

This comment has been minimized.

Copy link
@lukecarbis

lukecarbis Aug 27, 2019

Author Contributor

@gziolo @talldan Thanks for the tip! Implemented in 5652555.

Copy link
Contributor

left a comment

Looks great, thanks again for taking the time to fix this and congrats on your first merged PR 🎉

@talldan talldan merged commit 3594537 into WordPress:master Aug 28, 2019
1 of 4 checks passed
1 of 4 checks passed
Filter opened
Details
Filter opened
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@gziolo gziolo added this to the Gutenberg 6.5 milestone Aug 30, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
* Fix broken links on available SlotFills

* Use absolute paths in docs links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.