Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Disabled block count in the block manager #17103

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 20, 2019

Description

Part of: #15121

This PR adds a disabled block count to the block manager.

How has this been tested?

I opened the block manager with no disabled blocks and verified no count appears.
I opened the block manager with one disabled block and verified the message "1 block is disabled." appears.
I opened the block manager with eleven disabled blocks and verified the message "11 blocks are disabled." appears.

Screenshots

image

image

@youknowriad

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Works well, do we want to add the gray background like the mockup?

@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

Hi @youknowriad, I did not notice a gray background on the mockups, the mockup I used was this one:
image
Is there another mockup I should be aware?

@youknowriad

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Yes, that's the one I'm talking about. I see a very light gray background under the "8 blocks are disabled" message :). i guess the contrast is not very visible but maybe it's not that important to have a visible contrast here.

@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

I'm sorry, now I'm able to see it. I was using "Display Contrast" accessibility option that made the gray background unnoticeable. I will add the background 👍

@jorgefilipecosta jorgefilipecosta force-pushed the add/disabled-block-count-block-manager branch from 03107a2 to 146d004 Aug 20, 2019
Copy link
Contributor

left a comment

LGTM

Another design review might be good.

@mapk
mapk approved these changes Aug 21, 2019
Copy link
Contributor

left a comment

Looks wonderful! Thanks @jorgefilipecosta. :shipit:

@jorgefilipecosta jorgefilipecosta merged commit c9cbf8a into master Aug 21, 2019
4 checks passed
4 checks passed
Filter opened
Details
Filter opened
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the add/disabled-block-count-block-manager branch Aug 21, 2019
@senadir senadir added this to the Gutenberg 6.4 milestone Aug 25, 2019
donmhico added a commit to donmhico/gutenberg that referenced this pull request Aug 27, 2019
daniloercoli added a commit that referenced this pull request Sep 4, 2019
 into rnmobile/add-autosave-to-mobile

* 'rnmobile/master' of https://github.com/WordPress/gutenberg: (52 commits)
  [RNMobile] DarkMode improvements (#17309)
  Remove redundant bg color within button appender (#17325)
  Support group block on mobile (#17251)
  [RNMobile] Insure tapping at end of post inserts at end
  Recover border colors (#17269)
  [RNMobile] Fix dismiss keyboard button for the post title (#17260)
  Unify media placeholder and upload props within media-text (#17268)
  MediaUpload and MediaPlaceholder unify props (#17145)
  Add native support for the MediaText block (#16305)
  Activate Travis CI on rnmobile/master branch (#17229)
  [RNMobile] Native mobile release v1.11.0 (#17181)
  Apply box-sizing border-box properly to the notices components (#17066)
  Writing Flow: allow undo of patterns with BACKSPACE and ESC (#14776)
  Project automation: Rewrite actions using JavaScript (#17080)
  Build: remove global install of latest npm since we want to use the paired node/npm version (#17134)
  Writing Flow/Quote: allow splitting (#17121)
  Use `400` as a valid `font-weight`
  Add: Disabled block count in the block manager (#17103)
  Update video player style on mobile - Add a new gridicon play icon, from: https://github.com/Automattic/gridicons/blob/87c9fce08b4a9f184b9fb4963228757fdd4f4e74/svg-min/gridicons-play.svg - Replace the Dashicon play by this one - Update icon size and icon color - Update the overlay color
  [RNMobile] Hide replaceable block when adding block (#16931)
  ...

# Conflicts:
#	packages/block-editor/src/components/block-list/index.native.js
#	packages/block-editor/src/components/inserter/index.native.js
#	packages/block-editor/src/components/inserter/menu.native.js
#	packages/block-editor/src/components/media-placeholder/index.native.js
#	packages/block-editor/src/components/warning/index.native.js
#	packages/block-library/src/code/edit.native.js
#	packages/block-library/src/image/edit.native.js
#	packages/block-library/src/missing/edit.native.js
#	packages/block-library/src/more/edit.native.js
#	packages/block-library/src/nextpage/edit.native.js
#	packages/block-library/src/video/edit.native.js
#	packages/components/src/mobile/bottom-sheet/cell.native.js
#	packages/components/src/mobile/bottom-sheet/index.native.js
#	packages/components/src/mobile/dark-mode/index.native.js
#	packages/components/src/mobile/html-text-input/index.native.js
#	packages/components/src/toolbar/toolbar-container.native.js
#	packages/edit-post/src/components/header/header-toolbar/index.native.js
#	packages/edit-post/src/components/layout/index.native.js
#	packages/edit-post/src/components/visual-editor/index.native.js
#	packages/rich-text/src/component/index.native.js
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.