Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: Child blocks from block manager #17128

Merged

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 21, 2019

Description

Part of: #15121

This PR makes sure child blocks don't appear in the block manager, so we are consistent with the inserter currently they don't appear on the inserter by default.

How has this been tested?

I pasted the following code block in the browser console: https://gist.github.com/jorgefilipecosta/60a0bf242e8c7c18805618558268315d

I verified the Test Child block was not available in the block manager (on master it is).

@jorgefilipecosta jorgefilipecosta force-pushed the update/disable-child-blocks-from-block-manager branch from c39fcac to 3e49159 Aug 22, 2019
Copy link
Contributor

left a comment

I tested this and it looks great to me. Tested with the example code you provided as well as installing the "Atomic Blocks" plugin and verified that child blocks from the plugin were hidden in the block manager.

@jorgefilipecosta jorgefilipecosta merged commit a491a79 into master Sep 5, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the update/disable-child-blocks-from-block-manager branch Sep 5, 2019
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.