Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused css from ColorPalette component #17152

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 22, 2019

Description

This PR removes CSS code from the ColorPalette component that is not used anywhere.

Searching on all files of the repository for components-color-palette__clear-color and components-color-palette__clear-color-line does not return any occurrences (besides the removed CSS). That means the selector will never be used making the code useless.

If an element used this classes in an indirect way e.g. string concatenation the most probable file to do that would be https://github.com/WordPress/gutenberg//blob/8e18cafdf823c274c8f81ae16ca7b1cbf7f062f3/packages/components/src/color-palette/index.js and manually checking it we can see the classes are not used.

How has this been tested?

I verified the color pallet component still works as before.

Copy link
Contributor

left a comment

Good catch

@jorgefilipecosta jorgefilipecosta merged commit e8bc321 into master Aug 23, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the remove/unused-css-code-from-the-color-pallete-component branch Aug 23, 2019
@senadir senadir added this to the Gutenberg 6.4 milestone Aug 25, 2019
donmhico added a commit to donmhico/gutenberg that referenced this pull request Aug 27, 2019
dratwas added a commit to callstack/gutenberg that referenced this pull request Aug 28, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.