Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Refactor ColorPalette by extracting its design #17154

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 22, 2019

Description

This PR extracts the design from the ColorPalette component. So ColorPalette just contains the color-related functionality and CircularOptionPicker an internal component contains the UI to render a set of buttons as circles and a set of actions at the bottom.

We are implementing a set of Gradient presents #16662 (comment) so extracting this component allows us to use the same UI for the Gradient Presets without code repetition.

Missing updates to unit tests.

How has this been tested?

I checked that the color functionality still works exactly as before.

@jorgefilipecosta jorgefilipecosta force-pushed the update/extact-circular-option-picker-internal-component-containing-color-palette-design branch 5 times, most recently from 4b698cf to ccb0f00 Aug 23, 2019

@jorgefilipecosta jorgefilipecosta force-pushed the update/extact-circular-option-picker-internal-component-containing-color-palette-design branch from ccb0f00 to 89d00c5 Aug 30, 2019

@jorgefilipecosta jorgefilipecosta force-pushed the update/extact-circular-option-picker-internal-component-containing-color-palette-design branch from 89d00c5 to 1c1ebd2 Sep 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.