Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project management automation: Fix 'add first time contributor label' #17156

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@noisysocks
Copy link
Member

commented Aug 23, 2019

Octokit returns the search result count as data.total_count, not total_count.

I confirmed this in my local Node REPL:

$ node
> let { GitHub } = require( '@actions/github' )
> let octokit = new GitHub( 'INSERT_PERSONAL_ACCESS_TOKEN_HERE' )
> octokit.search.commits( { q: 'repo:WordPress/gutenberg+author:geriux' } ).then( ( result ) => console.log( result ) )
GitHub returns the search result count as `data.total_count`, not
`total_count`.
@talldan talldan merged commit ce46a4f into master Aug 23, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@talldan talldan deleted the fix/add-first-time-contributor-label branch Aug 23, 2019
donmhico added a commit to donmhico/gutenberg that referenced this pull request Aug 27, 2019
…WordPress#17156)

GitHub returns the search result count as `data.total_count`, not
`total_count`.
dratwas added a commit to callstack/gutenberg that referenced this pull request Aug 28, 2019
…WordPress#17156)

GitHub returns the search result count as `data.total_count`, not
`total_count`.
gziolo added a commit that referenced this pull request Aug 29, 2019
…#17156)

GitHub returns the search result count as `data.total_count`, not
`total_count`.
gziolo added a commit that referenced this pull request Aug 29, 2019
…#17156)

GitHub returns the search result count as `data.total_count`, not
`total_count`.
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
…WordPress#17156)

GitHub returns the search result count as `data.total_count`, not
`total_count`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.