Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Build: remove global install of latest npm since we want to use the paired node/npm version" #17171

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@gwwar
Copy link
Contributor

commented Aug 23, 2019

The Gutenberg project intentionally uses latest npm releases. I'd still recommend avoiding this to have a little less excitement with other project releases, but happy to prep this PR if folks are okay with it.

Testing Instructions

  • Travis is green
  • Run nvm uninstall v10.16.3
  • Run ./bin/setup-local-env.sh
  • We see an updated prompt to transparently run nvm install --latest-npm
$ ./bin/setup-local-env.sh 
WARNING: Node version does not match the latest long term support version. Please run this command to install and use it:
WARNING: nvm install --latest-npm
WARNING: After that, re-run the setup script to continue.
  • Running this command, we see that we download the active node LTS with latest npm:
  • Switching node versions will see this cached pairing.
$  nvm install --latest-npm
Found '/Users/kerryliu/checkouts/gutenberg/.nvmrc' with version <lts/*>
v10.16.3 is already installed.
Now using node v10.16.3 (npm v6.9.0)
Attempting to upgrade to the latest working version of npm...
* Installing latest `npm`; if this does not work on your node version, please report a bug!
/Users/kerryliu/.nvm/versions/node/v10.16.3/bin/npm -> /Users/kerryliu/.nvm/versions/node/v10.16.3/lib/node_modules/npm/bin/npm-cli.js
/Users/kerryliu/.nvm/versions/node/v10.16.3/bin/npx -> /Users/kerryliu/.nvm/versions/node/v10.16.3/lib/node_modules/npm/bin/npx-cli.js
+ npm@6.11.2
added 19 packages from 13 contributors, removed 15 packages and updated 53 packages in 6.584s
* npm upgraded to: v6.11.2

Reverts #17134

@gwwar gwwar requested review from ajitbohra, nerrad and ntwb as code owners Aug 23, 2019
@gwwar

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

Looks like this is still unhappy with npm v6.11.2

Screen Shot 2019-08-23 at 9 43 09 AM

So latest npm has not worked with this project for the last 3 days. I'd note that active node LTS/npm paired versions usually aren't that far behind, usually just a few minor versions.

@pento

This comment has been minimized.

Copy link
Member

commented Aug 24, 2019

Someone else was able to reproduce the same problem where I reported it to the NPM team, but no info on what the problem might be:

https://npm.community/t/6-11-1-some-dependencies-are-no-longer-being-installed/9586

@ntwb

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

I've discovered the regression introduced in npm 6.11.1 and added it to the discussion:

https://npm.community/t/6-11-1-some-dependencies-are-no-longer-being-installed/9586/7?u=netweb

@gwwar

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

For next steps, give the build a re-run if npm tries another release with the fix in https://github.com/npm/cli/releases

Feel free to ping me if they release and folks don't have permission to re-try the travis build.

…se the paired node/npm version (#17134)"

This reverts commit 0b4d9c8.
@pento pento force-pushed the revert-17134-try/pair-node-npm branch from c564f38 to aabe36d Sep 4, 2019
@pento
pento approved these changes Sep 4, 2019
Copy link
Member

left a comment

NPM 6.11.3 looks good, no changes to package-lock.json on my machine, and Travis tests now pass.

@pento pento modified the milestone: Gutenberg 6.5 Sep 4, 2019
@pento pento merged commit 0e55ef6 into master Sep 4, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@pento pento deleted the revert-17134-try/pair-node-npm branch Sep 4, 2019
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.