Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image flickering & focus lose on resizing #17175

Merged
merged 1 commit into from Aug 25, 2019

Conversation

@senadir
Copy link
Contributor

commented Aug 23, 2019

Description

fixes #17174
fixes #15420
handles problem in this comment #16475 (comment)

it deletes the selection toggling on the image on resize start & resize end

Copy link
Contributor

left a comment

Looks good, very similar to the fix I found for the spacer a while ago:
https://github.com/WordPress/gutenberg/pull/15884/files

@talldan talldan merged commit c158d75 into master Aug 25, 2019
1 of 4 checks passed
1 of 4 checks passed
Filter opened
Details
Filter opened
Details
Milestone It
Details
Travis CI - Pull Request Build Passed
Details
@talldan talldan deleted the fix/image-losing-focus-on-resize branch Aug 25, 2019
@senadir senadir added this to the Gutenberg 6.4 milestone Aug 25, 2019
donmhico added a commit to donmhico/gutenberg that referenced this pull request Aug 27, 2019
dratwas added a commit to callstack/gutenberg that referenced this pull request Aug 28, 2019
gziolo added a commit that referenced this pull request Aug 29, 2019
gziolo added a commit that referenced this pull request Aug 29, 2019
@senadir senadir referenced this pull request Sep 8, 2019
5 of 5 tasks complete
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.