Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fix post visibility null password edits. #17210

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@epiqueras
Copy link
Contributor

commented Aug 27, 2019

Fixes #17209

Description

This PR fixes the issue described in #17209.

The cause was that an old component incorrectly sets the post's password to null when publishing a post as private without a password. The API does not persist that edit so it would not clear after the response.

How has this been tested?

The expected behavior in #17209 was verified to occur.

Types of Changes

Bug Fix: Stop the post visibility component from setting passwords to null when publishing private posts.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@epiqueras epiqueras added this to the Gutenberg 6.4 milestone Aug 27, 2019
@epiqueras epiqueras requested a review from talldan as a code owner Aug 27, 2019
@epiqueras epiqueras self-assigned this Aug 27, 2019
@gziolo gziolo removed this from the Gutenberg 6.4 milestone Aug 27, 2019
Copy link
Member

left a comment

Fixes the problem in my tests 👍

@epiqueras epiqueras merged commit a6e85e6 into master Aug 27, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@epiqueras epiqueras deleted the fix/post-visibility-null-edits branch Aug 27, 2019
@talldan talldan modified the milestone: Gutenberg 6.4 Aug 29, 2019
@talldan

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Seems like this has introduced a different issue - #17247.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Tightening Up
  
Awaiting triage
4 participants
You can’t perform that action at this time.