Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few IE11 fixes #17214

Merged
merged 3 commits into from Aug 28, 2019

Conversation

@jasmussen
Copy link
Contributor

commented Aug 27, 2019

This PR tries to improve the situation for IE11, which is currently not that great.

Fixes #14330.

Fixes #10045.

Addresses parts of #17158.

Fixes probably unreported things too.

Before:

1

After the first commit it's no longer thick:

2

After the 2nd commit it's now usable:

3

And right-floats work:

4

Please test these if you can and let's get them in :)

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Aug 27, 2019
@jasmussen jasmussen self-assigned this Aug 27, 2019
@kjellr
kjellr approved these changes Aug 28, 2019
Copy link
Contributor

left a comment

Tested this out in IE, and it seems to work well. 👍 I did some light testing in Safari, Firefox, and Chrome too, but haven't seen any unintended issues.

Seems like a solid improvement!

@jasmussen

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

Thanks Kjell!

@jasmussen jasmussen merged commit 151d238 into master Aug 28, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jasmussen jasmussen deleted the try/ie11-fixes branch Aug 28, 2019
@gziolo gziolo added this to the Gutenberg 6.5 milestone Aug 30, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
* Fix toolbar thickness.

* Fix collapsing toolbar.

* Fix floated toolbar position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.