Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Fix cropped focus ring in block library #17215

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@jasmussen
Copy link
Contributor

commented Aug 27, 2019

Maybe fixes #17094 and maybe fixes #17168 too.

There's focus ring on blocks in the block library and the switcher. These are cropped when blocks are near the edges, due to an overflow: hidden;. This PR attempts to fix that with a deadpan negative margin. Will it work? This is where YOU come in!

Before:

63598879-72966e80-c58e-11e9-8a61-8d870dc60e39

After:

Screenshot 2019-08-27 at 15 56 45

Maybe fixes #17094 and maybe fixes #17168 too.

There's focus ring on blocks in the block library and the switcher. These are cropped when blocks are near the edges, due to an overflow: hidden;. This PR attempts to fix that with a deadpan negative margin. Will it work? This is where YOU come in!
@kjellr
kjellr approved these changes Aug 27, 2019
Copy link
Contributor

left a comment

Thanks, @jasmussen. This seems like a relatively solid fix for now. The main issue I see is that the hover state of one item can bump right up against the focus state of another now:

Screen Shot 2019-08-27 at 11 17 30 AM

I don't have any immediate ideas for that... perhaps a transparent border or something? But if we can't figure that out, I think this is still an improvement, so probably fine to merge as a fix for now.

@jasmussen

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

Thanks, I think that's a better state than master, a better holdover :)

@jasmussen jasmussen merged commit 51ec639 into master Aug 27, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jasmussen jasmussen deleted the try/block-library-focus-fix branch Aug 27, 2019
@mapk

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

Thanks for this @jasmussen! Sorry for the breakage. 😞

@jasmussen

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

Don't worry about it!

@gziolo gziolo added this to the Gutenberg 6.5 milestone Aug 30, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Maybe fixes WordPress#17094 and maybe fixes WordPress#17168 too.

There's focus ring on blocks in the block library and the switcher. These are cropped when blocks are near the edges, due to an overflow: hidden;. This PR attempts to fix that with a deadpan negative margin. Will it work? This is where YOU come in!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.