Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: Publish via full screen modal #17225

wants to merge 12 commits into
base: master


Copy link

commented Aug 27, 2019



This is a combination of an update to publish via a modal I am working on (#16715) and an alternative modal style change @youknowriad started (#16896) The purpose is to explore what publishing via a full-screen modal could potentially look like, as requested in #7602.

I wasn't sure the best way to track/share this as it's a combination of two work in progress PRs, and thought this would be the easiest, but if there is another way I'm happy to update.


@brentswisher brentswisher referenced this pull request Aug 27, 2019
2 of 5 tasks complete

This comment has been minimized.

Copy link

commented Aug 28, 2019

I can't help but think this is the wrong direction for the pre-publish confirmation.

With the full-screen modal we lose all sense of context. In a way, the full-screen modal is scary and confusing; It almost feels like something happened. But in reality, nothings happened yet.

Thats the opposite feeling we want to convey here. The confirmation screen should be reaffirming and comforting.

The main purposes of the pre-publish confirmation is to give you one last chance to make sure that things are ready to go — and by hiding the entirely of the post/page content we're not helping people confirm the action they're about to take.

I strongly recommend we do not use this full-screen modal for the pre-publish confirmation.


This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@shaunandrews thanks for the feedback! I tend to agree. Especially given the confusion that has been reported with clicking "Publish" not actually publishing but opening the pre-publish checks. With it being full screen, I wonder if there is an even greater chance of confusion if the post was actually published when the screen gets completely "taken over"? Would love to get your thoughts on moving it to a "normal" sized modal instead of a sidebar as well (#16715).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.