Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Image Block: Update media link when image is replaced #17226

Conversation

@donmhico
Copy link
Contributor

donmhico commented Aug 28, 2019

Description

Update the Media Link in the image block when the image is replaced.

How has this been tested?

  1. Confirmed the bug by following the steps provided in #17119.
  2. Applied the changes / additions.
  3. No longer able to reproduce the bug.

Types of changes

Fixes #17119.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
Copy link
Contributor

draganescu left a comment

I have tested this and it worked in fixing the link destination bug. The code is a simple update of the function used to set the a new image in the block onSelectImage and handles updating previously set props.

@draganescu draganescu merged commit 834a99b into WordPress:master Nov 19, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.