Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to fixtures in Testing Overview #17283

Merged
merged 3 commits into from Sep 2, 2019

Conversation

@mkaz
Copy link
Member

commented Aug 30, 2019

Description

Adds a link to Testing Overview document to the e2e tests fixtures that
are required for each core block.

How has this been tested?

Documentation, confirm link works as expected.

View on branch here.

Adds a link to Testing Overview document to the e2e tests fixtures that
are required for each core block.
@mkaz mkaz requested review from ajitbohra and chrisvanpatten as code owners Aug 30, 2019
@mkaz mkaz requested a review from jorgefilipecosta Aug 31, 2019
Copy link
Contributor

left a comment

This looks good, it's great to have more links to the more obscure tests.

I noticed some of the docs seem a bit outdated, so it'd be great to quickly update them.

docs/contributors/testing-overview.md Outdated Show resolved Hide resolved
docs/contributors/testing-overview.md Outdated Show resolved Hide resolved
@gziolo
gziolo approved these changes Sep 2, 2019
mkaz and others added 2 commits Sep 2, 2019
Co-Authored-By: Daniel Richards <daniel.richards@automattic.com>
Co-Authored-By: Daniel Richards <daniel.richards@automattic.com>
@mkaz mkaz merged commit 40e4a7c into master Sep 2, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@mkaz mkaz deleted the docs/add-fixtures-testing-link branch Sep 2, 2019
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
* Add link to fixtures in Testing Overview

Adds a link to Testing Overview document to the e2e tests fixtures that
are required for each core block.

* Update docs/contributors/testing-overview.md

Co-Authored-By: Daniel Richards <daniel.richards@automattic.com>

* Update docs/contributors/testing-overview.md

Co-Authored-By: Daniel Richards <daniel.richards@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.