Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixture generation documentation. #17285

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 31, 2019

Description

This PR fixes a command a link in the fixture generation documentation.

How has this been tested?

I deleted the following files:

packages/e2e-tests/fixtures/blocks/core__gallery__columns.json
packages/e2e-tests/fixtures/blocks/core__gallery__columns.parsed.json
packages/e2e-tests/fixtures/blocks/core__gallery__columns.serialized.html

I executed the following command:

GENERATE_MISSING_FIXTURES=y npm run test-unit test/integration/full-content/full-content.test.js

I verified the deleted files were regenerated.
I went to the following URL:
https://github.com/WordPress/gutenberg/blob/f34f58d5ff4abb58fa5fa643785aaf602d1d3e5d/packages/e2e-tests/fixtures/blocks/README.md

I pressed the full-content.spec.js link and I verified I did not get a 404 error.

@talldan
talldan approved these changes Sep 2, 2019
Copy link
Contributor

left a comment

👍

@talldan talldan merged commit e249061 into master Sep 2, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@talldan talldan deleted the fix/fixture-generation-documentation branch Sep 2, 2019
@gziolo gziolo modified the milestones: Gutenberg 6.5, Future Sep 2, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.