Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable declaration-block-no-duplicate-properties style lint rule; Fix existing case. #17287

Conversation

@jorgefilipecosta
Copy link
Member

commented Aug 31, 2019

This PR enables rule declaration-block-no-duplicate-properties.
And removes a case where we had a duplicate property.
I don't see a reason for disabling this rule as having a duplicate property in the same block is something we should avoid (just sents useless bytes over the wire).

…ove duplicate property.
@talldan
talldan approved these changes Sep 2, 2019
Copy link
Contributor

left a comment

Agreed, especially if this is the only instance as it looks like a dev mistake.

The only reason I can think for using duplicate properties are browser compatibility fixes (like the old school way of defining background-image: {browser-prefix}-linear-gradient( // ... ). I guess these are all handled by Post CSS these days?

@talldan talldan merged commit f198997 into master Sep 2, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@talldan talldan deleted the update/enabele-declaration-block-no-duplicate-properties-style-lint-rule-remove-duplicate-property branch Sep 2, 2019
@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

The only reason I can think for using duplicate properties are browser compatibility fixes (like the old school way of defining background-image: {browser-prefix}-linear-gradient( // ... ). I guess these are all handled by Post CSS these days?

Yes, I think post CSS handles these, cases but if there is a need to use a duplicate rule I guess we can use an exception and ignore the rule in that specific case.

@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.