Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sentence case for tooltips #17336

Merged
merged 3 commits into from Sep 13, 2019

Conversation

@mapk
Copy link
Contributor

commented Sep 4, 2019

Description

Fixes #16764 in part. I believe I've found all the tooltip instances that used title case and switched them to sentence case. I have not changed the labels in the popovers yet. I'm thinking that could be another PR to keep things simple. I'm starting to fiddle with a lot of files and it feel uncomfortable.

cc: @gziolo, I'd love to get your eyes on this to make sure I edited the correct files. If there are others I need to edit, let me know.

How has this been tested?

Locally.

Screenshots

Before:

61936717-95ccfe80-af8d-11e9-8fb0-c167ab258eb3

After:

Screen Shot 2019-09-04 at 4 14 21 PM

Types of changes

Non-breaking change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@gziolo

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Nice, some tests need to be updated as they apparently depend on those labels :)

@mapk

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Looks like @senadir updated some snapshots for me! Thanks! 💯

@gziolo I'm not sure how to correct the tests that need updating. Is this something you can guide me through?

@senadir

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

test still fails for some reason, Ithough I fixed all the outstanding issues, seems new ones showed up, I will restart the tests and see

as for finding the issues, you can go to the failed test building the "Details" link on right on the Travis check and then opening the failed job (ignore jobs that are allowed to fail)

you will have a long log, the failed checks are the ones that start with FAIL beside it, you will find the corresponding file to test, like

FAIL packages/e2e-tests/specs/adding-inline-tokens.test.js 
FAIL packages/e2e-tests/specs/block-transforms.test.js
@kjellr
kjellr approved these changes Sep 13, 2019
Copy link
Contributor

left a comment

This is a solid update, and it looks like the tests are now passing. Thanks, @mapk and @senadir!

@senadir senadir merged commit 1e2e08d into master Sep 13, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@senadir senadir deleted the update/sentence-case-labels branch Sep 13, 2019
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
* Using sentence case for tooltips. Fixes WordPress#16764 in part.

* update snapshots

* second try to match tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.