Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Group side menu option hide/show logic #17353

Conversation

@jorgefilipecosta
Copy link
Member

commented Sep 5, 2019

The "Group" option that appears on the block side menu correctly checked if the Group block can be inserted using canInsertBlockType but did not pass the rootBlockId. This caused bugs when in nested blocks where the group block can not be used the option to group still appears.

How has this been tested?

I added a Columns block with some columns inside.
I selected the column block and verified the "Group" side menu option does not appear (on master it appears but fails to do the action because a group is not allowed inside columns.

@jorgefilipecosta jorgefilipecosta requested a review from talldan as a code owner Sep 5, 2019
@jorgefilipecosta jorgefilipecosta requested a review from getdave Sep 5, 2019
@talldan
talldan approved these changes Sep 6, 2019
@talldan talldan merged commit ed5e063 into master Sep 6, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@talldan talldan deleted the fix/group-block-menu-option-appears-even-when-group-can-not-be-inserted branch Sep 6, 2019
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.