Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Gallery placeholder icon does not appear #17374


Copy link

commented Sep 8, 2019


In #17316 we added new icons to the icon file and removed the fault export but we did not update the import on the edit file and it still wrongly imported the default export.

This PR fixes the import on the gallery edit file.

How has this been tested?

I verified that the gallery icon appears on the media placeholder.

@jorgefilipecosta jorgefilipecosta requested a review from kjellr Sep 8, 2019
senadir approved these changes Sep 8, 2019
Copy link

left a comment

ah, kept seeing this error when I run npm run dev today, thank you for fixing it.

@jorgefilipecosta jorgefilipecosta merged commit d440728 into master Sep 8, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
@jorgefilipecosta jorgefilipecosta deleted the fix/gallery-placeholder-icon-not-appears-build-waring branch Sep 8, 2019
@jorgefilipecosta jorgefilipecosta changed the title Fix: Gallery placeholder icon does not appears Fix: Gallery placeholder icon does not appear Sep 8, 2019

This comment has been minimized.

Copy link

commented Sep 9, 2019

Whoops. Sorry about that. Thanks for the fix, @jorgefilipecosta!

@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.