Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Flipped color picker in RTL #17381

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@senadir
Copy link
Contributor

commented Sep 9, 2019

Description

fixes #17321
implements @hamedmoody solution

didn't implement this part since it's unrelated

div[data-type='core/paragraph'] .editor-block-toolbar.block-editor-block-toolbar div:nth-child(2) {
    direction: ltr;
}

How has this been tested?

  • switch to RTL
  • start setting a color
  • see that the color you're setting is the same as you selected.

Screenshots

backgroundcolor

@hamedmoody

This comment has been minimized.

Copy link

commented Sep 9, 2019

Switch in Persian(فارسی) language that is RTL
part of code is for that paragraph alignments tools that show at top of paragraph block:
left align is in right, right align is in left!
Not only paragraph, another block that has alignments has this alignment problem in RTL languages

@senadir

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

hey @hamedmoody can you open a separate issue for that (if there isn't one for it)? this is intended so we can keep a PR focused on a single problem since those are unrelated in what they fix

Copy link
Contributor

left a comment

Using the color picker seems not that performant. I wonder if we should debouce it or something like that. anyway, it's something to solve separately. Thanks.

@youknowriad youknowriad merged commit 90770c7 into master Sep 16, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the fix/fix-color-picker-on-rtl branch Sep 16, 2019
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 16, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
@hamedmoody

This comment has been minimized.

Copy link

commented Sep 27, 2019

Thanks guys, I create new issue with gif that describe problem in: Issue 17622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.