Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Links: Change default state to WordPress link instead of mail #17402

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@mkaz
Copy link
Member

commented Sep 11, 2019

Description

Per discussion in #17362 switch default link to WordPress instead of mail.
If unchanged, this will insert a valid link, whereas the mail link unchanged when be an invalid link.

The purpose of including a link prefilled is so the block does not "disappear" when unselected.

How has this been tested?

Confirm WordPress icon shows and is properly linked to https://wordpress.org/

Types of changes

Switches template for default state of the social-links/edit.js function.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@mkaz mkaz self-assigned this Sep 11, 2019
@mkaz mkaz requested a review from jasmussen Sep 11, 2019
@mkaz mkaz added the [Block] Social label Sep 11, 2019
Copy link
Contributor

left a comment

This is a good change.

@mkaz mkaz merged commit 90952f6 into master Sep 11, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@mkaz mkaz deleted the update/social-link-default-state branch Sep 11, 2019
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.