Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add className for Column in editor #17422

Merged
merged 12 commits into from Sep 14, 2019

Conversation

@HardeepAsrani
Copy link
Contributor

commented Sep 12, 2019

Description

Before this, the additional classes applied to column block didn't show up in the editor. This makes sure the class name takes effect in the editor.

It fixes: #17049

How has this been tested?

Tested it with browser tools to make sure the class name takes effect. Nothing much to test here.

Screenshots

Types of changes

Bugfix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

Not applicable to this:

  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
HardeepAsrani added 12 commits Nov 27, 2017
Update
Merge changes
Fix CodeEditor not loading when WordPress is installed in a subfolder…
Update the git
Merge
Rebase
Merge updates
Added `position` prop to DotTip component. Closes #14923
Rebase
Rebasee
Before this, the additional classes applied to column block didn't show
up in the editor.
@youknowriad youknowriad merged commit 0da78c7 into WordPress:master Sep 14, 2019
4 of 7 checks passed
4 of 7 checks passed
pull-request-automation
Details
Header rules - gutenberg-playground No header rules processed
Details
Pages changed - gutenberg-playground 3 new files uploaded
Details
Redirect rules - gutenberg-playground No redirect rules processed
Details
Mixed content - gutenberg-playground No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
netlify/gutenberg-playground/deploy-preview Deploy preview ready!
Details
@youknowriad youknowriad added this to the Gutenberg 6.5 milestone Sep 14, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.