Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rich Text: Add missing keep placeholder on focus prop. #17439
This PR fixes backwards compatibility issues that came with the unintentional removal of the
It does this by adding the prop back in.
How has this been tested?
It was verified that setting the
Types of Changes
Bug Fix: Fix backwards compatibility issues arising from accidentally removing the
I see one small issue: when the placeholder is kept on focus and you click on it, there is no caret visible. You can still type though. I see that the browser selection is somewhere after the placeholder, so we could enforce selection to be in the placeholder text element. Let's look at this separately.
This was also noted on #16733 (comment)
I'm a bit confused. If the placeholder (the span element) is not clickable, how can the click happen on the span element?
I think the placeholder should be ignored/"invisible" for clicks, and instead fall in the parent element. I'll have a look to fix this. In the meantime it might be worth creating a separate tracking issue for it.
* Rich Text: Add missing keep placeholder on focus prop. * Use text cursor for the placeholder * Turns out the cursor prop is not needed if the pointer-events prop is on the span instead of on the pseudo element