Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text: Add missing keep placeholder on focus prop documentation. #17445

Conversation

@epiqueras
Copy link
Contributor

commented Sep 15, 2019

Description

This PR follows #17439 to add missing documentation for the keepPlaceholderOnFocus prop.

How has this been tested?

It was read, haha.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
Copy link
Member

left a comment

Thanks! Alternatively you could restore it from https://github.com/WordPress/gutenberg/pull/16733/files. Up to you :)

@epiqueras epiqueras merged commit 8cd6295 into master Sep 15, 2019
4 of 7 checks passed
4 of 7 checks passed
pull-request-automation
Details
Header rules - gutenberg-playground No header rules processed
Details
Pages changed - gutenberg-playground All files already uploaded
Details
Redirect rules - gutenberg-playground No redirect rules processed
Details
Mixed content - gutenberg-playground No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
netlify/gutenberg-playground/deploy-preview Deploy preview ready!
Details
@epiqueras epiqueras deleted the add/missing-keep-placeholder-on-focus-rich-text-prop-documentation branch Sep 15, 2019
@gziolo

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

Cool, thank you!

It was read, haha.

Love it 🤣

@youknowriad youknowriad modified the milestones: Future, Gutenberg 6.5 Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.