Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText: fix invisible caret for placeholder on focus #17450

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@ellatrix
Copy link
Member

commented Sep 16, 2019

Description

Follow up to #17439. See #17439 (comment).

In Chrome, when a rich text instance is set to keep the placeholder on focus, the caret disappears on click. To fix the issue we can reset the selection to the correct one.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@ellatrix ellatrix requested a review from afercia Sep 16, 2019
@ellatrix ellatrix added this to the Gutenberg 6.5 milestone Sep 16, 2019
@youknowriad youknowriad referenced this pull request Sep 16, 2019
0 of 5 tasks complete
@youknowriad youknowriad merged commit 7740a67 into master Sep 16, 2019
4 of 7 checks passed
4 of 7 checks passed
pull-request-automation
Details
Header rules - gutenberg-playground No header rules processed
Details
Pages changed - gutenberg-playground 3 new files uploaded
Details
Redirect rules - gutenberg-playground No redirect rules processed
Details
Mixed content - gutenberg-playground No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
netlify/gutenberg-playground/deploy-preview Deploy preview ready!
Details
@youknowriad youknowriad deleted the try/fix-placeholder-caret branch Sep 16, 2019
@Djennez Djennez referenced this pull request Sep 17, 2019
5 of 9 tasks complete
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.