Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Data: Merge merged edits with the edited record value instead of the persisted one. #17455

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@epiqueras
Copy link
Contributor

commented Sep 16, 2019

Fixes #17384

Types of Changes

Bug Fix: Fixed an issue where editing a meta attribute would clear edits to other meta attributes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
… the persisted one.
@epiqueras epiqueras added this to the Future milestone Sep 16, 2019
@epiqueras epiqueras requested review from nerrad and youknowriad as code owners Sep 16, 2019
@epiqueras epiqueras self-assigned this Sep 16, 2019
Copy link
Contributor

left a comment

Thanks 👍

@youknowriad youknowriad merged commit 66d0ed9 into master Sep 16, 2019
4 of 7 checks passed
4 of 7 checks passed
pull-request-automation
Details
Header rules - gutenberg-playground No header rules processed
Details
Pages changed - gutenberg-playground 3 new files uploaded
Details
Redirect rules - gutenberg-playground No redirect rules processed
Details
Mixed content - gutenberg-playground No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
netlify/gutenberg-playground/deploy-preview Deploy preview ready!
Details
@youknowriad youknowriad deleted the fix/core-data-merged-edits branch Sep 16, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Tightening Up
  
Awaiting triage
2 participants
You can’t perform that action at this time.