Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add block examples for all core blocks #17493
I wonder if we should instead do something like this for the Group block?
I think you're right with a dark background. Maybe with a lighter background?
Also, I'm not sure why, but I don't get the colored text in my preview. And it's not registering with me visually as a "group".
jasmussen left a comment
I really like this. I think we should scramble to get it in.
On very slow connections it does surface a few improvements we can make to the preview component., but since that's only the first time you hover a block and then never after, I would not call that a blocker. Furthermore, it drastically improves the usability for sighted users of the block library, and it helps encourage 3rd party block developers to include a preview, that it's an important feature to ship.
However I think we should make a quick change. We are hotlinking the images, and we are using Unsplash. The latters license while very liberal, the suggestion to credit photographers makes it perhaps 0.05% less liberal than a strict interpretation of the GPL, which suggests complete and total freedom.
So just in order to be totally kosher, I would recommend replacing all images with certified public domain images from Wikimedia. Using this list https://commons.wikimedia.org/wiki/Featured_Pictures_in_the_Public_Domain I would suggest we could use the following:
An additional benefit is that Wikemedia explicitly permits hotlinking: https://commons.wikimedia.org/wiki/Commons:Reusing_content_outside_Wikimedia/technical
I hope to take a stab at replacing the URLs and returning.
The overall content, other than the images, are great, though, works well:
Okay, pushed good fastloading guaranteed publicdomain images that look good. These five, for reference:
Had to look for Mont Blanc and a specific bird due to the prose around them.
A couple more things before we can merge:
I will hopefully be back.
I just updated the video to be a very short and generic WordPress logo file. This is more appropriate for the preview where you can't even play it back. Plus the preview looks good:
With the help of @kjellr I'm investigating why it doesn't play back in Safari, as noted in the reviews. It may be the Make server.
jasmussen left a comment
As noted previously, I really like this. I think we should get it in.
I replaced all the images with Wikimedia images that are public domain. They also allow us to hotlink, so that helps. In addition, the files are small, so they load really fast compared the the previous images, and given they will be shown in scaled down previews the fidelity is fine.
I also removed the video, because the one we had did not play in Safari, and it should be hosted on a CDN. I created #17655 to track this.
What remains here is lovely, and I think it's good to go.
However I also did a bit of work on this, so would appreciate a sanity check, for example from @kjellr.