Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the Social Links plugin as experimental. #17526

Merged
merged 4 commits into from Sep 24, 2019

Conversation

@nicolad
Copy link
Member

commented Sep 23, 2019

Description

Applies feature flag as required here

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@@ -171,5 +171,7 @@ export const __experimentalRegisterExperimentalCoreBlocks = process.env.GUTENBER
__experimentalEnableLegacyWidgetBlock ? legacyWidget : null,
__experimentalEnableMenuBlock ? navigationMenu : null,
__experimentalEnableMenuBlock ? navigationMenuItem : null,
__experimentalEnableLegacyWidgetBlock ? socialLink : null,
__experimentalEnableLegacyWidgetBlock ? socialLinks : null,

This comment has been minimized.

Copy link
@youknowriad

youknowriad Sep 23, 2019

Contributor

Thanks for the PR @nicolad

Maybe we can just use process.env.GUTENBERG_PHASE === 2 as a test instead of __experimentalEnableLegacyWidgetBlock because If I'm not mistaken, this will ensure the block is always loaded in the plugin but not included in Core.

Can you confirm @talldan ?

This comment has been minimized.

Copy link
@nicolad

nicolad Sep 23, 2019

Author Member

Thanks @youknowriad, updated.

This comment has been minimized.

Copy link
@talldan

talldan Sep 25, 2019

Contributor

Looks good 👍

@mkaz

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

Also, I think socialLink itself is not a block, but you need ...socialLink.sites to get all the individual blocks.

@nicolad

This comment has been minimized.

Copy link
Member Author

commented Sep 23, 2019

Also, I think socialLink itself is not a block, but you need ...socialLink.sites to get all the individual blocks.

Thanks @mkaz

@nicolad nicolad requested a review from youknowriad Sep 24, 2019
Copy link
Contributor

left a comment

Thanks 👍

@youknowriad youknowriad added this to In progress in WordPress 5.3 Must Have Sep 24, 2019
@youknowriad youknowriad merged commit 20cde36 into master Sep 24, 2019
4 of 7 checks passed
4 of 7 checks passed
pull-request-automation
Details
Header rules - gutenberg-playground No header rules processed
Details
Pages changed - gutenberg-playground 3 new files uploaded
Details
Redirect rules - gutenberg-playground No redirect rules processed
Details
Mixed content - gutenberg-playground No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
netlify/gutenberg-playground/deploy-preview Deploy preview ready!
Details
WordPress 5.3 Must Have automation moved this from In progress to Done Sep 24, 2019
@youknowriad youknowriad deleted the feature-flag/social-links branch Sep 24, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
@nicolad nicolad self-assigned this Sep 29, 2019
@youknowriad youknowriad added this to the Gutenberg 6.6 milestone Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.