Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show help panel when launched from top bar #17545

Merged
merged 1 commit into from Sep 25, 2019

Conversation

@talldan
Copy link
Contributor

commented Sep 24, 2019

Description

Only displays the inserter help panel for the inserter in the top bar.

Closes #17520
Fixes #17177

The change:
The InserterMenu already has a showInserterHelpPanel prop passed in from its withSelect higher order component. This HOC now requires that the showInserterHelpPanel prop is explicity declared as true on the component as well for the help to be displayed.

How has this been tested?

  1. Create a new post
  2. Open the inserter menu from the top bar
  3. Observe it has a help panel
  4. Add a group or columns block to the post
  5. Click on the + button appender in the group or columns block
  6. Observe that the inserter menu has no help panel

Screenshots

Screen Shot 2019-09-24 at 4 06 29 pm

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@gziolo
gziolo approved these changes Sep 24, 2019
Copy link
Member

left a comment

Code looks good 👍

@mapk
mapk approved these changes Sep 24, 2019
Copy link
Contributor

left a comment

Great work, @talldan. That was quick. This works and looks good from a design perspective. 👍 :shipit:

@talldan talldan force-pushed the update/only-show-inserter-help-from-top-bar branch from 4b286ce to 88d8856 Sep 25, 2019
@talldan talldan merged commit 85bf428 into master Sep 25, 2019
4 of 7 checks passed
4 of 7 checks passed
pull-request-automation
Details
Header rules - gutenberg-playground No header rules processed
Details
Pages changed - gutenberg-playground 3 new files uploaded
Details
Redirect rules - gutenberg-playground No redirect rules processed
Details
Mixed content - gutenberg-playground No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
netlify/gutenberg-playground/deploy-preview Deploy preview ready!
Details
@talldan talldan deleted the update/only-show-inserter-help-from-top-bar branch Sep 25, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
@youknowriad youknowriad added this to the Gutenberg 6.6 milestone Sep 30, 2019
@youknowriad youknowriad removed the [Type] Bug label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.