Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
RichText: remove Editable & allow React to diff editable element #17779
This PR eliminates our own diffing for attributes on the content editable element.
How has this been tested?
Types of changes
aduth left a comment
If I understand correctly, the changes here aren't actually leveraging React to do the rendering of the RichText record?
Even still, I think the benefits here are pretty great, and serve as a nice overall simplification.
I would be curious as well what the measurable performance difference is here, if any (seems there ought to be some improvement to key presses?).
Most of my review comments are minor nit-picks. Functionally, it works great. The only thing I'd consider really blocking is the priority with which we're applying ARIA props seems to have changed.
No, it's just letting React manage the editable element, not its contents. I'd like to explore that in the future, but I ran into some problems with it. React can't seem to update a DOM tree if the current tree is not in a shape that it's expecting. Anyway, that's a different problem.
I think that, while there is a bit less work being done, the difference is negligible, especially compared to all the work that's being done outside of