Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Popover: consistently adjust position on scroll #17867
Currently some popovers won't reposition when the page is scrolled. These include: the link popover, image, and autocomplete.
The problem is that the rectangle is NOT calculated by
So I added a few more props for the
How has this been tested?
Open the link, image, or slash command popover. Scroll the page.
Types of changes
mcsf left a comment
This is looking quite good. From the code I'm only wondering about performance in
But the only thing that really matters is overall performance impact. Our perf suite is focused entirely on typing, but it's all we have for now. Have you compared perf results against master for this branch?
There should be no difference in perf, but if there were that would be a smell to address. :)
Looks like it's the opposite. Master is a tiny bit slower.